Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drtprod: put tpcc init and run scripts on workload-scale #132162

Closed
wants to merge 1 commit into from

Conversation

vidit-bhat
Copy link
Contributor

This patch ensures that we put the tpcc_init.sh
and tpcc_run.sh file while creating workload-scale

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This patch ensures that we put the `tpcc_init.sh`
and `tpcc_run.sh` file while creating `workload-scale`

Epic: none
Release note: None
@vidit-bhat vidit-bhat marked this pull request as ready for review October 8, 2024 12:58
@vidit-bhat vidit-bhat requested a review from a team as a code owner October 8, 2024 12:58
@vidit-bhat vidit-bhat requested review from herkolategan, renatolabs, shailendra-patel and nameisbhaskar and removed request for a team October 8, 2024 12:58
export ROACHPROD_DNS="drt.crdb.io"
./roachprod sync
sleep 20
PGURLS=$(./roachprod pgurl drt-scale:1-150 | sed s/\'//g)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: passing only cluster name drt-scale would give pgurl for all nodes. In case if we decide to not have exact 150 nodes.

PGURLS=$(./roachprod pgurl drt-scale:1-150 | sed s/\'//g)

./cockroach workload init tpcc \
--warehouses 3000 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 150 scale node the plan is to have 150K warehouses.


set -o pipefail

TPCC_DB=cct_tpcc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why are we changing the db name from tpcc to cct_tpcc.

@@ -34,7 +36,7 @@ while true; do
--tolerate-errors \
--password tpcc \
--families \
"${PGURLS_ARR[@]}" | tee $LOG
$PGURLS | tee $LOG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--warehouses 3000, --active-warehouses 1500 value of this flags need to be changed.

Also we need to think about values of following flags to get the cpu around 60%.

-concurrency 128
--max-rate 7000 

@nameisbhaskar
Copy link
Contributor

As discussed, lets hold back on this change. I would prefer it to be more generic scripts that takes inputs from teh YAML file for parameters like warehouses. This can go in after #131942 changes. After that I have another change in the queue where we have parameterised tpocc init.

Copy link
Contributor

@nameisbhaskar nameisbhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will revisit this.

@vidit-bhat
Copy link
Contributor Author

Closed in favour of #132307

@vidit-bhat vidit-bhat closed this Oct 15, 2024
@vidit-bhat vidit-bhat deleted the tpcc-drt-scale branch October 15, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants