storage: use cluster version in benchmark data key #133489
Conversation
Incorporate the cluster version into the storage package's microbenchmark fixture data naming scheme. This avoids failures due to attempting to open a store at an unsupported cluster version. Fix cockroachdb#133384. Epic: none Release note: none
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/storage/bench_data_test.go line 213 at r1 (raw file):
key := []string{ "mvcc", fmt.Sprintf("cv_%s", clusterversion.PreviousRelease.Version()),
@RaduBerinde — any reason you know of not to use clusterversion.Latest here?
There was a problem hiding this comment.
Reviewable status:
pkg/storage/bench_data_test.go line 213 at r1 (raw file):
Previously, jbowens (Jackson Owens) wrote…
@RaduBerinde — any reason you know of not to use
clusterversion.Latesthere?
Just that the name would change every time we add another gate
|
TFTR! bors r=RaduBerinde |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #133384: branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Incorporate the cluster version into the storage package's microbenchmark fixture data naming scheme. This avoids failures due to attempting to open a store at an unsupported cluster version.
Fix #133384.
Epic: none
Release note: none