Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-10949] Update Docker instructions for Cloud-first #18839

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Aug 19, 2024

[DOC-10949] Update Docker instructions for Cloud-first

  • Also externalize Docker instructions into a version-specific include
  • Also convert HTML to Markdown

This is related to #18826 but I separated it out on purpose so that I can rebase this one on that one's work.

Sending for initial review before backporting to more versions

Previews

src/current/v24.2/install-cockroachdb-mac.md
src/current/v24.2/install-cockroachdb-windows.md
src/current/v24.2/install-cockroachdb-linux.md

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 5d0a628
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67196aa4ac20b300086f94f1

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 5d0a628
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67196aa492f784000893d5a7

Copy link

netlify bot commented Aug 19, 2024

Netlify Preview

Name Link
🔨 Latest commit 5d0a628
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67196aa44dd9f10008ce7587
😎 Deploy Preview https://deploy-preview-18839--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

Suggest getting a cursory review from someone in #release-engineering so they're informed

src/current/_includes/v24.2/install-docker-steps.md Outdated Show resolved Hide resolved
src/current/_includes/v24.2/install-docker-steps.md Outdated Show resolved Hide resolved
src/current/_includes/v24.2/install-docker-steps.md Outdated Show resolved Hide resolved
src/current/_includes/v24.2/install-docker-steps.md Outdated Show resolved Hide resolved
@mdlinville mdlinville merged commit 1dbf391 into main Oct 23, 2024
6 checks passed
@mdlinville mdlinville deleted the DOC-10949 branch October 23, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants