MOLT Fetch failback mode #18990

taroface · 2024-10-04T19:32:14Z

Preview links:

netlify · 2024-10-04T19:32:44Z

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	`4cd9b18`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/671a8ab3b8f1d2000817d6cf

netlify · 2024-10-04T19:32:45Z

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	`4cd9b18`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/671a8ab3fe321a0008b0dd22

github-actions · 2024-10-04T19:33:35Z

Files changed:

src/current/molt/molt-fetch.md

netlify · 2024-10-04T19:36:03Z

❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →

Name	Link
🔨 Latest commit	`5ee36f5`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/670042c0fc8f7e0009c6cb9d

netlify · 2024-10-04T19:38:56Z

✅ Netlify Preview

Name	Link
🔨 Latest commit	`4cd9b18`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/671a8ab3f3906400087fc1d8
😎 Deploy Preview	https://deploy-preview-18990--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

taroface · 2024-10-14T15:09:36Z

@ryanluu12345 Friendly ping for review!

src/current/molt/molt-fetch.md

taroface · 2024-10-17T21:17:38Z

@ryanluu12345 Updated. PTAL!

src/current/molt/molt-fetch.md

ryanluu12345 · 2024-10-22T20:04:25Z

@taroface as a note, we want to call attention to this technical advisory: https://www.cockroachlabs.com/docs/advisories/a123371#mitigation

Basically, we want to call out the impact and link it. But basically, you can just link this in the docs and then let people know to do versions greater than:

Mitigation
Users of CockroachDB v22.2, v23.1.0 to v23.1.21, and v23.2.0 to v23.2.5 are encouraged to upgrade to v23.1.22, v23.2.6, v24.1.0, or a later version.

Impact
Changefeeds could drop events during the initial scan in some cases, causing changefeed consumers to receive incomplete data. Versions affected include CockroachDB v22.2, v23.1.0 to v23.1.21, v23.2.0 to v23.2.5, and testing versions of v24.1 through v24.1.0-rc.1.

Questions about any technical alert can be directed to our support team.

src/current/molt/molt-fetch.md

rohan-joshi

docs lgtm

ryanluu12345

Latest technical advisory changes look good to me. Thanks! I'm good with this PR now.

ryanluu12345 · 2024-10-23T18:10:12Z

src/current/molt/molt-fetch.md

+#### Fail back to source database
+
+{{site.data.alerts.callout_danger}}
+Before using `failback` mode, refer to the [technical advisory]({% link advisories/a123371.md %}) about a bug that affects changefeeds on CockroachDB v22.2, v23.1.0 to v23.1.21, v23.2.0 to v23.2.5, and testing versions of v24.1 through v24.1.0-rc.1.


@Jeremyyang920 FYI here

florence-crl

lgtm pending suggestions.

src/current/molt/molt-fetch.md

florence-crl · 2024-10-23T18:40:34Z

src/current/molt/molt-fetch.md

+~~~
+
+{{site.data.alerts.callout_info}}
+If both `--changefeeds-path` and `--allow-tls-mode-disable` are not specified in `failback` mode, `molt fetch` will error. At least one of these flags is required. `--changefeeds-path` overrides the default changefeed configuration. `--allow-tls-mode-disable` enables the use of the default changefeed configuration, which is insecure.


Suggested change

If both `--changefeeds-path` and `--allow-tls-mode-disable` are not specified in `failback` mode, `molt fetch` will error. At least one of these flags is required. `--changefeeds-path` overrides the default changefeed configuration. `--allow-tls-mode-disable` enables the use of the default changefeed configuration, which is insecure.

Either

- `--changefeeds-path` which overrides the default changefeed configuration, or

- `--allow-tls-mode-disable` which enables the use of the default insecure changefeed configuration

must be specified in `failback` mode, otherwise `molt fetch` will error.

Adapted this to be clearer, as you rightly suggest. I'm not a fan of placing bullet points in the middle of a sentence as this doesn't look entirely right to me. Instead, I wrote it into a full sentence without bullet points.

src/current/molt/molt-fetch.md

florence-crl · 2024-10-23T18:51:41Z

src/current/molt/molt-fetch.md

+  WITH updated, resolved = '1s', min_checkpoint_frequency = '1s', initial_scan = 'no', cursor = '2024-09-11T16:33:35Z', webhook_sink_config = '{\"Flush\":{\"Bytes\":1048576,\"Frequency\":\"1s\"}}'
+~~~
+
+This results in initial output like the following:


This may be redundant, but for clarity:

Suggested change

This results in initial output like the following:

Running the preceding `molt fetch` command or the equivalent `CREATE CHANGEFEED` command results in initial output like the following:

I don't want to suggest manually running that changefeed command, so I slightly reworded.

Co-authored-by: Florence Morris <[email protected]>

taroface force-pushed the molt-fetch-failback branch from 5ee36f5 to 4cfe90b Compare October 4, 2024 19:33

taroface requested review from ryanluu12345 and rohan-joshi October 4, 2024 19:48

ryanluu12345 reviewed Oct 14, 2024

View reviewed changes

ryanluu12345 reviewed Oct 21, 2024

View reviewed changes

src/current/molt/molt-fetch.md Outdated Show resolved Hide resolved

ryanluu12345 reviewed Oct 21, 2024

View reviewed changes

src/current/molt/molt-fetch.md Outdated Show resolved Hide resolved

ryanluu12345 reviewed Oct 22, 2024

View reviewed changes

src/current/molt/molt-fetch.md Show resolved Hide resolved

ryanluu12345 approved these changes Oct 22, 2024

View reviewed changes

taroface requested a review from florence-crl October 22, 2024 17:31

ryanluu12345 reviewed Oct 22, 2024

View reviewed changes

src/current/molt/molt-fetch.md Outdated Show resolved Hide resolved

rohan-joshi reviewed Oct 23, 2024

View reviewed changes

ryanluu12345 approved these changes Oct 23, 2024

View reviewed changes

ryanluu12345 reviewed Oct 23, 2024

View reviewed changes

florence-crl approved these changes Oct 23, 2024

View reviewed changes

taroface force-pushed the molt-fetch-failback branch from a01616f to b3eeae7 Compare October 24, 2024 17:54

taroface added 7 commits October 24, 2024 13:57

MOLT Fetch failback mode

99c4a6e

update links

6278f87

address review comment

6f5e4db

reorganize Failback docs per change to default behavior

29246b7

fix anchor link

0362c7c

address review comments

309a64e

emphasize secure changefeed connection

d801d61

taroface and others added 6 commits October 24, 2024 13:57

link to TA; expand admonition about MySQL versions

4851e84

add CRDB versions for TA

1cde99f

remove extraneous shell formatting

e8a44fc

Apply suggestions from code review

d6df1dc

Co-authored-by: Florence Morris <[email protected]>

further review tweaks

46fe580

port PK change

4cd9b18

taroface force-pushed the molt-fetch-failback branch from b3eeae7 to 4cd9b18 Compare October 24, 2024 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MOLT Fetch failback mode #18990

MOLT Fetch failback mode #18990

taroface commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024

netlify bot commented Oct 4, 2024

netlify bot commented Oct 4, 2024 •

edited

Loading

taroface commented Oct 14, 2024

taroface commented Oct 17, 2024

ryanluu12345 commented Oct 22, 2024

rohan-joshi left a comment

ryanluu12345 left a comment

ryanluu12345 Oct 23, 2024

florence-crl left a comment

florence-crl Oct 23, 2024

taroface Oct 24, 2024 •

edited

Loading

florence-crl Oct 23, 2024

taroface Oct 24, 2024

-If both `--changefeeds-path` and `--allow-tls-mode-disable` are not specified in `failback` mode, `molt fetch` will error. At least one of these flags is required. `--changefeeds-path` overrides the default changefeed configuration. `--allow-tls-mode-disable` enables the use of the default changefeed configuration, which is insecure.
+Either
+- `--changefeeds-path` which overrides the default changefeed configuration, or
+- `--allow-tls-mode-disable` which enables the use of the default insecure changefeed configuration
+must be specified in `failback` mode, otherwise `molt fetch` will error.

	This results in initial output like the following:
	Running the preceding `molt fetch` command or the equivalent `CREATE CHANGEFEED` command results in initial output like the following:

MOLT Fetch failback mode #18990

Are you sure you want to change the base?

MOLT Fetch failback mode #18990

Conversation

taroface commented Oct 4, 2024 • edited Loading

netlify bot commented Oct 4, 2024 • edited Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

netlify bot commented Oct 4, 2024 • edited Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

github-actions bot commented Oct 4, 2024

Files changed:

netlify bot commented Oct 4, 2024

❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →

netlify bot commented Oct 4, 2024 • edited Loading

✅ Netlify Preview

taroface commented Oct 14, 2024

taroface commented Oct 17, 2024

ryanluu12345 commented Oct 22, 2024

rohan-joshi left a comment

Choose a reason for hiding this comment

ryanluu12345 left a comment

Choose a reason for hiding this comment

ryanluu12345 Oct 23, 2024

Choose a reason for hiding this comment

florence-crl left a comment

Choose a reason for hiding this comment

florence-crl Oct 23, 2024

Choose a reason for hiding this comment

taroface Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

florence-crl Oct 23, 2024

Choose a reason for hiding this comment

taroface Oct 24, 2024

Choose a reason for hiding this comment

taroface commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

netlify bot commented Oct 4, 2024 •

edited

Loading

taroface Oct 24, 2024 •

edited

Loading