-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOLT Fetch failback mode #18990
base: main
Are you sure you want to change the base?
MOLT Fetch failback mode #18990
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
5ee36f5
to
4cfe90b
Compare
Files changed: |
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ryanluu12345 Friendly ping for review! |
@ryanluu12345 Updated. PTAL! |
@taroface as a note, we want to call attention to this technical advisory: https://www.cockroachlabs.com/docs/advisories/a123371#mitigation Basically, we want to call out the impact and link it. But basically, you can just link this in the docs and then let people know to do versions greater than: Mitigation Impact Questions about any technical alert can be directed to our support team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest technical advisory changes look good to me. Thanks! I'm good with this PR now.
#### Fail back to source database | ||
|
||
{{site.data.alerts.callout_danger}} | ||
Before using `failback` mode, refer to the [technical advisory]({% link advisories/a123371.md %}) about a bug that affects changefeeds on CockroachDB v22.2, v23.1.0 to v23.1.21, v23.2.0 to v23.2.5, and testing versions of v24.1 through v24.1.0-rc.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jeremyyang920 FYI here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending suggestions.
src/current/molt/molt-fetch.md
Outdated
~~~ | ||
|
||
{{site.data.alerts.callout_info}} | ||
If both `--changefeeds-path` and `--allow-tls-mode-disable` are not specified in `failback` mode, `molt fetch` will error. At least one of these flags is required. `--changefeeds-path` overrides the default changefeed configuration. `--allow-tls-mode-disable` enables the use of the default changefeed configuration, which is insecure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both `--changefeeds-path` and `--allow-tls-mode-disable` are not specified in `failback` mode, `molt fetch` will error. At least one of these flags is required. `--changefeeds-path` overrides the default changefeed configuration. `--allow-tls-mode-disable` enables the use of the default changefeed configuration, which is insecure. | |
Either | |
- `--changefeeds-path` which overrides the default changefeed configuration, or | |
- `--allow-tls-mode-disable` which enables the use of the default insecure changefeed configuration | |
must be specified in `failback` mode, otherwise `molt fetch` will error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted this to be clearer, as you rightly suggest. I'm not a fan of placing bullet points in the middle of a sentence as this doesn't look entirely right to me. Instead, I wrote it into a full sentence without bullet points.
src/current/molt/molt-fetch.md
Outdated
WITH updated, resolved = '1s', min_checkpoint_frequency = '1s', initial_scan = 'no', cursor = '2024-09-11T16:33:35Z', webhook_sink_config = '{\"Flush\":{\"Bytes\":1048576,\"Frequency\":\"1s\"}}' | ||
~~~ | ||
|
||
This results in initial output like the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be redundant, but for clarity:
This results in initial output like the following: | |
Running the preceding `molt fetch` command or the equivalent `CREATE CHANGEFEED` command results in initial output like the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to suggest manually running that changefeed command, so I slightly reworded.
a01616f
to
b3eeae7
Compare
b3eeae7
to
4cd9b18
Compare
DOC-10978
Preview links: