Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include liquid from markdown table on restore sql page #19044

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented Oct 23, 2024

Fixes DOC-11541

The restore option table was not rendering properly due to include file liquid in the table. (Liquid does not work in markdown tables.) This PR removes that include from the table and leans on the already existing link to the section that also includes this content. Removed the include file from the repo as well because it was only used in this table and lower down on the same page. Added the content in place in the section.

Copy link

github-actions bot commented Oct 23, 2024

Files changed:

  • src/current/_includes/v23.1/backups/skip-localities-check-serverless.md:
    • Warning: include not used in any v23.1 file or include
  • src/current/_includes/v23.2/backups/skip-localities-check-serverless.md:
    • Warning: include not used in any v23.2 file or include
  • src/current/_includes/v24.1/backups/skip-localities-check-serverless.md:
    • Warning: include not used in any v24.1 file or include
  • src/current/_includes/v24.2/backups/skip-localities-check-serverless.md:
    • Warning: include not used in any v24.2 file or include
  • src/current/_includes/v24.3/backups/skip-localities-check-serverless.md:
    • Warning: include not used in any v24.3 file or include
  • src/current/v23.1/restore.md
  • src/current/v23.2/restore.md
  • src/current/v24.1/restore.md
  • src/current/v24.2/restore.md
  • src/current/v24.3/restore.md

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 522d9d0
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/671ab174c745510008ad1f05

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 522d9d0
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/671ab174f785060009d8b5f6

Copy link

netlify bot commented Oct 23, 2024

Netlify Preview

Name Link
🔨 Latest commit 522d9d0
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/671ab174435ce30008fae9a3
😎 Deploy Preview https://deploy-preview-19044--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kathancox kathancox merged commit 264ee51 into main Oct 24, 2024
6 checks passed
@kathancox kathancox deleted the restore-option-table-render branch October 24, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants