-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reflection probe #17388
Merged
Merged
add reflection probe #17388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -37136,8 +37136,14 @@
export function getEditorPipelineSettings(): object | null;
export function forceResizeAllWindows(): void;
export function defaultWindowResize(ppl: BasicPipeline, window: renderer.RenderWindow, width: number, height: number): void;
export function dispatchResizeEvents(cameras: renderer.scene.Camera[], builder: PipelineBuilder, ppl: BasicPipeline): void;
+ /**
+ * @en Three channel rgb color pack into four channel rbge format.
+ * @zh 三通道rgb颜色pack成四通道rbge格式
+ * @param rgb Vec3
+ */
+ export function packRGBE(rgb: math.Vec3): math.Vec4;
}
export namespace postProcess {
export class PostProcessSetting extends Component {
onEnable(): void;
|
…3.8.4-pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
minggo
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reflection probe support. Fix planar reflection probe problem of native app.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
ReflectionProbe
class in/native/cocos/scene/ReflectionProbe.cpp
builtin-pipeline.ts
to handle reflection probes in the editor