Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reflection probe #17388

Merged
merged 9 commits into from
Jul 22, 2024
Merged

add reflection probe #17388

merged 9 commits into from
Jul 22, 2024

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Jul 18, 2024

Add reflection probe support. Fix planar reflection probe problem of native app.

Changelog

  • Add reflection probe support.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

  • Added ReflectionProbe class in /native/cocos/scene/ReflectionProbe.cpp
  • Implemented planar and cubemap reflection rendering methods
  • Enhanced builtin-pipeline.ts to handle reflection probes in the editor
  • Added camera transformation and bounding box calculations
  • Implemented texture initialization and management for baked cubemaps

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

github-actions bot commented Jul 18, 2024

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -37136,8 +37136,14 @@
         export function getEditorPipelineSettings(): object | null;
         export function forceResizeAllWindows(): void;
         export function defaultWindowResize(ppl: BasicPipeline, window: renderer.RenderWindow, width: number, height: number): void;
         export function dispatchResizeEvents(cameras: renderer.scene.Camera[], builder: PipelineBuilder, ppl: BasicPipeline): void;
+        /**
+         * @en Three channel rgb color pack into four channel rbge format.
+         * @zh 三通道rgb颜色pack成四通道rbge格式
+         * @param rgb Vec3
+         */
+        export function packRGBE(rgb: math.Vec3): math.Vec4;
     }
     export namespace postProcess {
         export class PostProcessSetting extends Component {
             onEnable(): void;

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@star-e star-e requested a review from minggo July 22, 2024 02:10
@star-e star-e merged commit 8fbc04d into cocos:v3.8.4 Jul 22, 2024
23 checks passed
@star-e star-e deleted the v3.8.4-pipeline branch July 22, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants