fix render window attach camera and resize logic #17414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Interface Check ReportThis pull request does not change any public interfaces ! |
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
minggo
reviewed
Jul 25, 2024
| export function dispatchResizeEvents (cameras: Camera[], builder: PipelineBuilder, ppl: BasicPipeline): void { | ||
| if (!builder.windowResize) { | ||
| // No game window resize handler defined. | ||
| // Following old prodecure, do nothing | ||
| return; | ||
| } | ||
|
|
||
| // Resize all windows. | ||
| // Notice: A window might be resized multiple times with different cameras. | ||
| // User should avoid resource collision between different cameras. |
There was a problem hiding this comment.
What will happen if two or more cameras have have the same size?
There was a problem hiding this comment.
The custom pipeline resize logic of the specific render window will be called multiple times with different cameras.
This is by design, in order to:
- Reduce memory usage by reusing resources of the render window.
- Share render targets between different cameras.
User can also use camera name/index, to avoid collision if they really want.
There was a problem hiding this comment.
The cameras' sizes are the same of the render window.
minggo
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new camera is attached to the render window, the render window will be set resized. The custom pipeline will update all associated resources.
Fix window resize logic, it will be resized multiple times with different cameras. User should reuse render window's resource and avoid collision.
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request:
Greptile Summary
The pull request improves the handling of render window resizing and camera attachment logic to prevent multiple resize operations and resource collisions.
_isResizedflag incocos/render-scene/core/render-window.tsto track window resize state._resizedWindowsarray incocos/rendering/custom/framework.tsto manage resized windows and reset flags post-processing.attachCameramethod incocos/render-scene/core/render-window.tsto set_isResizedflag when a new camera is attached.dispatchResizeEventsfunction incocos/rendering/custom/framework.tsto handle multiple cameras and avoid redundant resizing.native/cocos/scene/RenderWindow.cppto align with the new resize and camera attachment logic.