Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to avoid msvc optimization #17426

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Jul 26, 2024

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Greptile Summary

Refactored updateRenderWindow method in NativePipeline.cpp to avoid MSVC optimization issues by separating width and height assignments from descriptor updates.

  • Refactored native/cocos/renderer/pipeline/custom/NativePipeline.cpp to improve updateRenderWindow method.
  • Ensured width and height are set correctly before updating the descriptor.
  • Aimed to improve code reliability when compiled with MSVC.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@star-e star-e merged commit f5688fe into cocos:v3.8.4 Jul 26, 2024
24 checks passed
@star-e star-e deleted the v3.8.4-fix-memory branch July 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants