[v3.8.5] cclegacy.xxx invocations should be converted to relevant type which will help refactoring and error reporting. #17753
+166
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e which will help refactoring and error reporting.
dumganhar
commented
Oct 21, 2024
| if (err) { | ||
| error(err.message, err.stack); | ||
| } else if (sceneAsset.scene) { | ||
| const scene = sceneAsset.scene; | ||
| scene._id = sceneAsset._uuid; | ||
| scene.id = sceneAsset._uuid; |
There was a problem hiding this comment.
_id 是 protected property, use id setter instead.
👍 Package size ⤵ -203 bytes, old: 5446634, new: 5446431Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -23776,9 +23776,9 @@
csmLayers: __private._cocos_rendering_shadow_csm_layers__CSMLayers;
octree: renderer.scene.Octree;
skin: renderer.scene.Skin;
postSettings: renderer.scene.PostSettings;
- lightProbes: any;
+ lightProbes: LightProbes;
/**
* @en The list for valid punctual Lights, only available after the scene culling of the current frame.
* @zh 场景中精确的有效光源，仅在当前帧的场景剔除完成后有效。
*/
|
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details |
|
@dumganhar, Please check the result of
Task Details |
minggo
reviewed
Oct 22, 2024
| /** | ||
| * @engineInternal | ||
| */ | ||
| public _releaseDescriptorSetCache (textureHash: number | Texture | null, sampler: Sampler | null = null): void { |
There was a problem hiding this comment.
- It is better to modify the comment too, as it is not a private method now.
- Why add type
nullfor textureHash?
minggo
reviewed
Oct 22, 2024
| @@ -318,7 +318,7 @@ export class Skybox { | |||
| this._default = builtinResMgr.get<TextureCube>('default-cube-texture'); | |||
|
|
|||
| if (!this._model) { | |||
| this._model = cclegacy.director.root.createModel(cclegacy.renderer.scene.Model) as Model; | |||
| this._model = (cclegacy.director.root as Root).createModel(cclegacy.renderer.scene.Model as typeof Model); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: