-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.8.5] cclegacy.xxx invocations should be converted to relevant type which will help refactoring and error reporting. #17753
base: v3.8.5
Are you sure you want to change the base?
Conversation
…e which will help refactoring and error reporting.
if (err) { | ||
error(err.message, err.stack); | ||
} else if (sceneAsset.scene) { | ||
const scene = sceneAsset.scene; | ||
scene._id = sceneAsset._uuid; | ||
scene.id = sceneAsset._uuid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_id 是 protected property, use id
setter instead.
👍 Package size ⤵ -203 bytes, old: 5446634, new: 5446431Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -23776,9 +23776,9 @@
csmLayers: __private._cocos_rendering_shadow_csm_layers__CSMLayers;
octree: renderer.scene.Octree;
skin: renderer.scene.Skin;
postSettings: renderer.scene.PostSettings;
- lightProbes: any;
+ lightProbes: LightProbes;
/**
* @en The list for valid punctual Lights, only available after the scene culling of the current frame.
* @zh 场景中精确的有效光源,仅在当前帧的场景剔除完成后有效。
*/
|
@cocos-robot run test cases |
@dumganhar, Please check the result of
Task Details |
@dumganhar, Please check the result of
Task Details |
/** | ||
* @engineInternal | ||
*/ | ||
public _releaseDescriptorSetCache (textureHash: number | Texture | null, sampler: Sampler | null = null): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It is better to modify the comment too, as it is not a private method now.
- Why add type
null
for textureHash?
@@ -318,7 +318,7 @@ export class Skybox { | |||
this._default = builtinResMgr.get<TextureCube>('default-cube-texture'); | |||
|
|||
if (!this._model) { | |||
this._model = cclegacy.director.root.createModel(cclegacy.renderer.scene.Model) as Model; | |||
this._model = (cclegacy.director.root as Root).createModel(cclegacy.renderer.scene.Model as typeof Model); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can not use as Model
?
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: