Skip to content

code-423n4/2024-10-superposition

Repository files navigation

Superposition audit details

  • Total Prize Pool: $21,000 in USDC
    • HM awards: $17,400 in USDC
    • Judge awards: $1,900 in USDC
    • Validator awards: $1,200 in USDC
    • Scout awards: $500 in USDC
  • Read our guidelines for more details
  • Starts October 18, 2024 20:00 UTC
  • Ends November 1, 2024 20:00 UTC

ℹ️ While there are no QA awards, QA reports are encouraged as a fallback in the event of no valid HMs.

Automated Findings / Publicly Known Issues

The 4naly3er report can be found here.

Note for C4 wardens: Anything included in this Automated Findings / Publicly Known Issues section is considered a publicly known issue and is ineligible for awards.

  • It is possible for someone to grief the protocol by creating a pool with bad configuration.
  • It is possible for the permissioned account to do things to grief the protocol.
  • Operator makes a mistake with a trusted function
  • It is possible to frontrun certain operater permissioned functions

Overview

Longtail is a concentrated liquidity AMM powered by Arbitrum Stylus. Arbitrum Stylus is a WASM frontend to the EVM on Arbitrum.

Longtail differs from a traditional V3 AMM in the following ways:

  1. One contract for everything: Liquidity is centralised in one contract.
  2. One shared asset between every pool: fUSDC is shared between every pool.
  3. Contract addresses are embedded in the compiled code: Contract addresses are set using environment variables.
  4. Native support for permit2: Permit2 is natively supported for a better UX.
  5. Diamond-like proxy for dispatch: A Solidity contract is used to delegatecall to different facets of the contract.

See pkg/README.md for deployment addresses and more details.

Links


Scope

See scope.txt

Files in scope

File SLOC
pkg/seawater/src/maths/sqrt_price_math.rs 1239
pkg/seawater/src/lib.rs 812
pkg/seawater/src/pool.rs 428
pkg/seawater/src/wasm_erc20.rs 332
pkg/seawater/src/maths/swap_math.rs 316
pkg/seawater/src/maths/tick_math.rs 254
pkg/seawater/src/error.rs 151
pkg/seawater/src/tick.rs 146
pkg/seawater/src/maths/bit_math.rs 138
pkg/seawater/src/types.rs 112
pkg/seawater/src/maths/full_math.rs 106
pkg/seawater/src/position.rs 87
pkg/seawater/src/maths/tick_bitmap.rs 47
pkg/seawater/src/maths/liquidity_math.rs 37
pkg/seawater/src/immutables.rs 23
pkg/seawater/src/maths/utils.rs 11
pkg/seawater/src/maths/mod.rs 9
pkg/seawater/src/maths/unsafe_math.rs 9
pkg/seawater/src/permit2_types.rs 8
pkg/seawater/src/erc20.rs 5
pkg/seawater/src/events.rs 3
Total 4273

Files out of scope

See out_of_scope.txt

Scoping Q & A

General questions

Question Answer
ERC20 used by the protocol USDC
Test coverage N/A
ERC721 used by the protocol OwnershipNFTs
ERC777 used by the protocol None
ERC1155 used by the protocol None
Chains the protocol will be deployed on Superposition

External integrations (e.g., Uniswap) behavior in scope:

Question Answer
Enabling/disabling fees (e.g. Blur disables/enables fees) No
Pausability (e.g. Uniswap pool gets paused) No
Upgradeability (e.g. Uniswap gets upgraded) No

EIP compliance checklist

N/A

Additional context

Main invariants

The concentrated liquidity math should be as reasonably similar to Uniswap's as possible.

Attack ideas (where to focus for bugs)

  1. Any discrepancies with Uniswap in an end to end environment
  2. Fee taking isn't correct. Full ticks aren't correct?

All trusted roles in the protocol

Role Description
Operator Controls access to the repo, and implementation addresses.
Emergency Council Can shut the dapp down if needed.
NFT manager Allows addresses to control their ownership of assets as a NFT.

Describe any novel or unique curve logic or mathematical models implemented in the contracts:

Concentrated liquidity math

Running tests

See pkg/README for a detailed explanation

Then run the following command:

https://github.com/code-423n4/2024-10-superposition
cd 2024-10-superposition/pkg
rustup target add wasm32-unknown-unknown
cargo install cargo-stylus
./tests.sh # this would test the rust files from the files in `tests`.

Miscellaneous

Employees of Superposition and employees' family members are ineligible to participate in this audit.

Code4rena's rules cannot be overridden by the contents of this README. In case of doubt, please check with C4 staff.