Skip to content
This repository has been archived by the owner on Sep 19, 2018. It is now read-only.

Modifying pyploma.py in order to take the year of the event from command line. #446

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

misshu93
Copy link

No description provided.

@mitio
Copy link
Member

mitio commented Oct 17, 2016

@misshu93 thanks for the suggested contribution!

Can you explain in a bit more detail what are you changing and why?

The current way you're proposing the change will break the automatic certificate generation and we can't merge it as is.

@misshu93
Copy link
Author

Oh, you're right... Alessandro asked me to modify this script in order to take the year from command line but I think he say me the wrong repo... Anyway, I tried to run your script but it seems not generate anything. Is this script finished?

@mitio
Copy link
Member

mitio commented Oct 17, 2016

The code uses this file to generate the certificates. It is finished and works properly.

It was originally derived from the pyploma.py script, but has since then been heavily modified. You've replaced the new file with the old pyploma.py script and that would not work. You've also added a few old files which are no longer used. You've probably done that by mistake.

The new code is called by the events website when an event organizer reports the details from his or her event. We then automatically generate the certificate for organizing an event.

There's also the option to invoke the certificate generation from the command line, using Django's commands, see here.

I'm not sure why @alessandrobogliolo wants a year to be passed on the command line, as the year is taken from the event's date, but if it needs to be passed anyway, the change should probably be done in the command.

@alessandrobogliolo
Copy link
Contributor

I think there is some misunderstanding. I asked to take the year from the
starting date of the event the certificate is associated to. I think this
is exactly what Dimitar has done. Hence, I think no other actions are
required for certificates of recognition.

Other certificates will be discussed afterwards.

Thanks

A
Il 17/Ott/2016 10:33 "Dimitar Dimitrov" [email protected] ha
scritto:

The code uses this file to generate the certificates
https://github.com/codeeu/coding-events/blob/fe65e1b5f1aa071629173f7282c25bbb5763881c/certificates/generator.py.
It is finished and works properly.

It was originally derived from the pyploma.py script, but has since then
been heavily modified. You've replaced the new file with the old
pyploma.py script and that would not work. You've also added a few old
files which are no longer used. You've probably done that by mistake.

The new code is called by the events website when an event organizer
reports the details from his or her event. We then automatically generate
the certificate for organizing an event.

There's also the option to invoke the certificate generation from the
command line, using Django's commands, see here
https://github.com/codeeu/coding-events/blob/fe65e1b5f1aa071629173f7282c25bbb5763881c/api/management/commands/generate_certificate.py
.

I'm not sure why @alessandrobogliolo
https://github.com/alessandrobogliolo wants a year to be passed on the
command line, as the year is taken from the event's date, but if it needs
to be passed anyway, the change should probably be done in the command.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#446 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIPCH8C-hVZOe07n9Fz92iWA7DpblHh7ks5q0zLUgaJpZM4KYFT3
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants