Surveyor view: Load My Account data #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r handling and loading
* state restoration on logout made more concise * fix account data error message * camelCase function name in EditAccount
mattdelsordo
requested changes
Jun 19, 2023
| }, | ||
| }, | ||
| }); | ||
| return updatedAccount; |
There was a problem hiding this comment.
You should make sure this updates the user object as well, otherwise if they change their email here they won't be able to use that to log in.
There was a problem hiding this comment.
Meeting note: Maybe surveyor shouldn't have email at all, just user.
There was a problem hiding this comment.
@mattdelsordo I'm not entirely sure how to update a user.
There was a problem hiding this comment.
I looked into this a bit, and it seems like this might be a bit more complicated than just doing a PATCH. I say for now, just don't let the user edit their email or password.
|
Another thing that's probably out of scope for this particular thing is that we should allow surveyors to change their passwords on this screen. |
*EditAccount uses controlled HeatPump[Etc.] field components.
* surveyors_controller: add email to list of allowed search params * Account: grab account data via email address using new rtkq hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads account data for surveyor My Account page and displays it, with error handling and page loading.
To complete: