Fixing formatting for total contributions, improved perf for images, added team data #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychoy
changed the title
alessandro-pianetta
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The format for total contributions is incorrect.
Solution: Wrote up functions to determine which suffix to append and to modify the value displayed. Previous function only worked for numbers in the thousands. Current implementation is a temporary solution. This wouldn't work if numbers weren't in the billions.
Issue:
Performance is impacted by current format of pictures. According to Lighthouse report, we can improve performance by 8 seconds if we reformat images to webp format.
I also added some current and former team members per contribution history from previous repos:
https://github.com/codeforsanjose/opendsj-2018
https://github.com/codeforsanjose/opendsj
For most of the alumni data, I'm not sure if they were frontend/backend or had another role...so I added full stack for now.
TODO for us to update in the future.
Addresses part of the audit: #188