Development #2
Open
Development #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 15, 2022 15:43
Implement all core features. All tests, except for stretch features, passing.
and inserts to correct spot in HTML
got right number of classes; all tests are now passing
|
1 suggestion with git (no need to change anything with this comment as well). With git you can push more commits, or amend work to the original PR where Peter reviewed. Doing this will provide a clean history in git to track your work. |
ajmajma
approved these changes
Jun 17, 2022
| addTotalsRow(reportCardTableElement); | ||
| addGpaRow(reportCardTableElement); | ||
| addUpStudentCredits(reportCardTableElement); | ||
| calculateSemesterGpa(reportCardTableElement); |
There was a problem hiding this comment.
Nice job in breaking these down into individual responsibilities!
| @@ -213,7 +262,7 @@ function openDropdown(dropdownElement) { | |||
| * | |||
| */ | |||
| function updateDropdownLabel() { | |||
| // code goes here | |||
| dropdownLabelElement.innerHTML = semester; | |||
There was a problem hiding this comment.
nit - semester is in an outer scope. You can avoid future confusion by passing it directly to this function.
| @@ -266,9 +340,18 @@ function addUpStudentCredits(reportCardTableElement) { | |||
| */ | |||
|
|
|||
| function calculateSemesterGpa(reportCardTableElement) { | |||
| // code goes here | |||
| let grades = Array.from(reportCardTableElement.querySelectorAll('.gpa')).filter((grade) => grade.innerHTML in gpaPointsLookup); | |||
There was a problem hiding this comment.
gpaPointsLookup is outer scoped as well. This will work fine for your scenario, but you can save yourself some future debugging pain by explicitly passing all the variables you need for your functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have incorporated your suggestions. Kindly let me know if I'm missing anything.