Spurious empty lines in log #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eading empty string if the input ends with a newline. This resulted in spurious empty lines in log because of the buffering.
nijel
added a commit
to WeblateOrg/docker
that referenced
this pull request
Jul 22, 2020
It includes following fixes: - coderanger/supervisor-stdout#12 - coderanger/supervisor-stdout#18 - coderanger/supervisor-stdout#20 Fixes #736
|
The patch works fine. The screenshot shows the patched stage system, while the other ones have the standard version: The non-staging systems have many empty log lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it's the same issue of #11, but each time the event handler was called with a bunch of lines to log, it added a new empty line because split('\n') returns a leading empty string when the input ends with a newline.