[Lily] 4-4w #40
Open
[Lily] 4-4w #40
+158
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangdaddy
reviewed
May 5, 2023
|
|
||
| for (let j = 0; j < words.length; j++) { | ||
| if (word === words[j]) { | ||
| answer += j |
There was a problem hiding this comment.
객체로 키, 값을 주는것만 생각하고 배열로 간단하게 인덱스 값으로 해당 words의 숫자를 주는 생각을 못했네요. 하드코딩 적어지고 심플하고 좋네요!
sarangdaddy
reviewed
May 5, 2023
Comment on lines
+66
to
+67
| let arr = answer.split(numbers[i]) | ||
| answer = arr.join(i) |
There was a problem hiding this comment.
와... 배열 메서드 활용 짱이네요.. join은 진짜 생각도 못했네
sarangdaddy
approved these changes
May 5, 2023
|
|
||
| for (let i = 0; i <= t.length - len; i++) { | ||
| const numbers = t.slice(i, i + p.length) | ||
| if (+numbers <= +p) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.