Do not log the exception before attempting an non-blocking dial #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
block
argument is not specified or is set toNone
during a call todial()
, the library tries to do a blocking connection first.If a
pynng.ConnectionRefused
occurs, the exception is logged using the global logger and then a non-blocking connection is attempted.In my opinion the exception should not be logged (especially using the global logger).
I've spent 2 hours figuring out that the exception displayed in my terminal does not occur in my code and is "normal" because I did not specified the
block
argument 😀Here a small code example:
The output without this patch:
The output with this patch: