Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor out ProblemConfig #46

Merged
merged 10 commits into from
Jul 4, 2024

Conversation

TobyBoyne
Copy link
Collaborator

Much of the functionality of ProblemConfig has been deferred to the Feature classes. This removes a lot of unnecessary if isinstance(feat, ...) checks, instead relying on each Feature to implement the functionality. Introduces the Ordinal class to make checking for not Categorical simpler, and to share logic across the ordinal features.

Also works towards #42.

@TobyBoyne TobyBoyne merged commit a500fcd into cog-imperial:master Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant