Directly using and serializing gym.spaces and their value #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloderic
force-pushed
the
directly_use_gym_spaces
branch
7 times, most recently
from
bff5f3f
to
3abf16c
Compare
cloderic
force-pushed
the
directly_use_gym_spaces
branch
from
3abf16c
to
470933f
Compare
wduguay-air
previously approved these changes
Jan 24, 2023
cloderic
added a commit
that referenced
this pull request
Jan 24, 2023
* Directly using and serializing gym.spaces and their value * Introducing debug inspector of received observation on the web side * Take into account review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115
cogment_verse.specs.Spaceandcogment_verse.specs.SpaceValueclasses in favour of directly usinggym.spaces.Spaceinstances andnp.arraydirectly. Introducecogment_verse.specs.EnvironmentSpecs,cogment_verse.specs.ObservationSpace,cogment_verse.specs.ActionSpaceas (relatively) thin wrapper around gym stuffs. Remove customflatten,unflatten,samplefunctions in favor of using Gym's.np.arrayon the javascript side to open the door to implementing rendering on the client side. Currently using that for action mask and for a new debug display showing the observation tensor:To reviewer -> Take a look a the changes in actors and environment to get an understanding of the API changes, this is the "last" API change I'd like to consider before merging
nextinmain.