Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Custom 404 and 500 page added #64

Closed
wants to merge 2 commits into from
Closed

Custom 404 and 500 page added #64

wants to merge 2 commits into from

Conversation

mukesh663
Copy link
Member

This is my first pull request. Check once, if everything's correct.

@naresh-kumar-babu naresh-kumar-babu linked an issue Mar 10, 2021 that may be closed by this pull request
@naresh-kumar-babu naresh-kumar-babu added bug Something isn't working good first issue Good for newcomers Priority This issue is Important labels Mar 10, 2021
@sanjay-thiyagarajan
Copy link
Contributor

@mukesh663 Great work. Can you share the screenshots of the pages here ?

@sanjay-thiyagarajan
Copy link
Contributor

Also, I can see that the PR mentions that 658 files have changed. Kinda weird. Can you summarise your changes in points here ?

@mukesh663
Copy link
Member Author

Also, I can see that the PR mentions that 658 files have changed. Kinda weird. Can you summarise your changes in points here ?

First, when I set debug=false, it showed some internal server error. It was caused due to the path specified for STATIC_ROOT in settings.py. Actually the staticfiles directory didn't exist or for some reason it was not found. So I used 'python manage.py collectstatic' command, which made those 658 file changes.

Some, server errors were caused by the forward slashes that were mentioned in the html pages for including the bootstrap and css. These errors were ignored when debug is set to true.

I have also included the images of custom error pages.

404_errorPage
500_errorPage
stackex

@mukesh663
Copy link
Member Author

@sanjay-thiyagarajan Can you check now, I have removed the duplicated files.
Only the json file is kept in staticfiles directory and removed other files.

@sanjay-thiyagarajan
Copy link
Contributor

@sanjay-thiyagarajan Can you check now, I have removed the duplicated files.
Only the json file is kept in staticfiles directory and removed other files.

@mukesh663 yeah this looks good. Try finding an attractive design for both these pages. It need not be the same background provided for working pages.

Copy link
Contributor

@sanjay-thiyagarajan sanjay-thiyagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the UI of these pages. It might make the visitor bored.

@sanjay-thiyagarajan
Copy link
Contributor

@mukesh663 Are you still working on this issue ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers Priority This issue is Important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants