Completed Source_PhysicalServer workflow #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyashish
reviewed
Jan 15, 2020
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| Default: true, | ||
| Description: `Forcefully register physical server to target cluster`, |
There was a problem hiding this comment.
Double quotes .. consistent with below.
| } | ||
|
|
||
| func resourceCohesitySourcePhysicalServerCreate(resourceData *schema.ResourceData, configMetaData interface{}) error { | ||
| log.Printf("[INFO] Starting PS Registration") |
There was a problem hiding this comment.
Replace PS with Physical Server.
|
|
||
| if err != nil { | ||
| log.Printf(err.Error()) | ||
| return errors.New("Failed to register Cohesity protection source") |
There was a problem hiding this comment.
better to add the protection source type ? Physical Server
| } | ||
|
|
||
| func resourceCohesitySourcePhysicalServerRead(resourceData *schema.ResourceData, configMetaData interface{}) error { | ||
| log.Printf("Starting Read") |
There was a problem hiding this comment.
Be consistent with logging [INFO] or [DEBUG]
| return errors.New("Failed to authenticate with Cohesity") | ||
| } | ||
|
|
||
| protectionSourceID, _ := strconv.ParseInt(resourceData.Id(), 10, 64) |
There was a problem hiding this comment.
can you add a comment here to tell what strconv.ParseInt(resourceData.Id(), 10, 64) this is doing
| if *protectionSource.ProtectionSource.Name == endpoint { | ||
| log.Printf("[INFO] Found the Physical Server protection source %s on cohesity cluster", endpoint) | ||
| //validate the Physical Server Source Registration | ||
| if *protectionSource.LogicalSize == 0 { |
There was a problem hiding this comment.
why are you checking the logical size here, we can just check the name, if its there then return nil
|
|
||
| // *protectionSource.RegistrationInfo.AccessInfo.Endpoint != endpoint { | ||
| // return fmt.Errorf("Failed to valaidate created physical server source") | ||
| // } |
There was a problem hiding this comment.
Can you pls remove all the commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.