Converting from HLG to from_map #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would prefer just requiring a minimum version that definitely supports from_map |
What would this minimum version be? |
|
Pinning to at least the first version that has Dask-Expr enabled would make sense Users of older dask version would just pull the previous release |
3 tasks
|
@phofl @jrbourbeau I think this is good to go, the failing tests c.f. deprecation of 3.7 and 3.8 |
|
Can you drop the ci jobs? |
|
Ah sorry, just merge main and the failures will go away |
|
And you'll have to update the minimum python version in setup.py |
phofl
approved these changes
Jul 5, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phofl @fjetter
Replacing HLG with
dd.from_mapto enable dask_expr functionality. Reverts to existing method if dask version doesn't supportfrom_map.