Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction on pandas version #64

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Remove restriction on pandas version #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f121f
Remove restrictions for pandas version
hendrikmakait Nov 13, 2024
dbae472
Avoid connectionless execution
hendrikmakait Nov 13, 2024
620f3c5
Naming
hendrikmakait Nov 13, 2024
285cfeb
Wrap in text
hendrikmakait Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dask_snowflake/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pytest
import snowflake.connector
from snowflake.sqlalchemy import URL
from sqlalchemy import create_engine
from sqlalchemy import create_engine, text

import dask
import dask.dataframe as dd
Expand All @@ -29,7 +29,8 @@ def table(connection_kwargs):
yield name

engine = create_engine(URL(**connection_kwargs))
engine.execute(f"DROP TABLE IF EXISTS {name}")
with engine.connect() as conn:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#implicit-and-connectionless-execution-bound-metadata-removed

conn.execute(text(f"DROP TABLE IF EXISTS {name}"))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#execute-method-more-strict-execution-options-are-more-prominent



@pytest.fixture(scope="module")
Expand Down
5 changes: 0 additions & 5 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,3 @@ dask>=2024.3.0
distributed
snowflake-connector-python[pandas]>=2.6.0
snowflake-sqlalchemy
# `pandas=2.2` dropped support for `sqlalchemy<2`, but `snowflake-sqlalchemy`
# doesn't support `sqlalchemy>=2` yet. Temporarily pinning `pandas<2.2` for now.
# xref https://github.com/pandas-dev/pandas/issues/57049
# xref https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380
pandas<2.2
Loading