Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ERC1271InputGenerator): fix code start with 0xef error by adding 0xff as first byte #71

Closed
wants to merge 1 commit into from

Conversation

xenoliss
Copy link
Contributor

It is possible that the computed replaySafeHash begins with 0xef. In such a case, our implementation, inspired by this example, would result in a contract bytecode also starting with 0xef.

With the London upgrade, create and create2 calls will fail if the deployed bytecode begins with 0xef.

This PR updates the constructor of the ERC1271InputGenerator contract to prefix the returned replaySafeHash with a constant 0xff byte. This prevents the aforementioned error from occurring.

@vegeta321311
Copy link

0x331a94dac38795536d418a18cbaaf315d3188684

davyus.eth

twitter X. @Sdavyus

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 28, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for asslover6996 @ 2024-08-02 12:22:53 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for Sturgeontara06 @ 2024-09-24 21:50:29 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

Review Error for Sturgeontara06 @ 2024-09-24 21:50:37 UTC
User must have write permissions to review

Copy link

@Sturgeontara06 Sturgeontara06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to do but need access to my funds

Copy link

@OKEAMAH OKEAMAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

@cb-heimdall
Copy link
Collaborator

Review Error for OKEAMAH @ 2024-09-27 09:32:08 UTC
User must have write permissions to review

@xenoliss
Copy link
Contributor Author

Closing as outdated.

@xenoliss xenoliss closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants