-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ERC1271InputGenerator): fix code start with 0xef
error by adding 0xff
as first byte
#71
Conversation
0x331a94dac38795536d418a18cbaaf315d3188684 davyus.eth twitter X. @Sdavyus |
🟡 Heimdall Review Status
|
Review Error for asslover6996 @ 2024-08-02 12:22:53 UTC |
Review Error for Sturgeontara06 @ 2024-09-24 21:50:29 UTC |
Review Error for Sturgeontara06 @ 2024-09-24 21:50:37 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do but need access to my funds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y
Review Error for OKEAMAH @ 2024-09-27 09:32:08 UTC |
Closing as outdated. |
It is possible that the computed
replaySafeHash
begins with0xef
. In such a case, our implementation, inspired by this example, would result in a contract bytecode also starting with0xef
.With the London upgrade,
create
andcreate2
calls will fail if the deployed bytecode begins with0xef
.This PR updates the constructor of the
ERC1271InputGenerator
contract to prefix the returnedreplaySafeHash
with a constant0xff
byte. This prevents the aforementioned error from occurring.