Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update HBD/HBA calc for Lipinski #51

Merged
merged 9 commits into from
Oct 17, 2023

Conversation

RPirie96
Copy link
Collaborator

@RPirie96 RPirie96 commented Oct 5, 2023

Really silly proposed change to how the Lipinski's Rule of 5 calculation is implemented! Chatting with Greg at the UGM last week, and he pointed out that in the original paper the HBA count is defined specifically as the "sum of Ns and Os" and HBD as the "sum of OHs and NHs". His recommendation was to use the rules as defined rather than trying to improve them by using the "correct" HBA/HBD counts.

Copy link
Collaborator

@bieniekmateusz bieniekmateusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll add that in the changelog as a note and then update the minor version, and then merge it. 👍

@bieniekmateusz bieniekmateusz merged commit 1c071d6 into cole-group:master Oct 17, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants