Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker - Update bindings.sh to Use Environment Variables Directly #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

turbra
Copy link

@turbra turbra commented Nov 8, 2024

When using docker-compose or podman-compose, the .env.local configuration can now be passed directly via the following command, removing the requirement for a volume mount:

podman-compose --env-file .env.local up -d
  • Updated bindings.sh to retrieve and use environment variables directly, rather than relying on reading from .env.local as a volume mount.
  • Enhanced security by handling sensitive information through environment variables instead of file-based configuration.
  • Simplified setup, especially for users who prefer not to use volume mounts for injecting configuration files into containers.

@chrismahoney
Copy link
Collaborator

chrismahoney commented Nov 9, 2024

@coleam00 it seems like we have some constraints on PR titles here that fail the automation checks, is it possible for us to loosen those a bit as we get started just in order to see valid compilation passes on new pull requests? This one is failing due to the first char of the title being uppercase for example.

@chrismahoney chrismahoney self-requested a review November 9, 2024 02:39
@chrismahoney
Copy link
Collaborator

I’ll review this in the meantime.

@thecodacus
Copy link

just make the "Docker" to docker
i believe its following conventionalcommits format.
so after the pr type the first character in the subject should be lower case
feat: docker... will fix the issue

@turbra turbra changed the title feat: Docker - Update bindings.sh to Use Environment Variables Directly feat: docker - Update bindings.sh to Use Environment Variables Directly Nov 9, 2024
@coleam00
Copy link
Owner

coleam00 commented Nov 9, 2024

@chrismahoney I don't even remember setting this rules up haha so it might be something default set up! Like @thecodacus said it's conventional naming. But I am certainly okay making it more loose too.

@chrismahoney chrismahoney added the duplicate This issue or pull request already exists label Nov 14, 2024
@chrismahoney
Copy link
Collaborator

Tagging to cover with #276 post provider refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants