fix #526 #550
Merged
fix #526 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yassirasad and @Lx does this fix work for you folks? |
src/icalendar/tests/test_unit_cal.py
Outdated
| 'issue_178_custom_component_contains_other', | ||
| 'issue_178_custom_component_inside_other', | ||
| 'issue_526_calendar_with_events', | ||
| 'issue_526_calendar_with_different_events', |
There was a problem hiding this comment.
If the lists are always supposed to be equal, they could be in one variable.
| @@ -436,6 +436,22 @@ def __repr__(self): | |||
| subs = ', '.join(str(it) for it in self.subcomponents) | |||
| return f"{self.name or type(self).__name__}({dict(self)}{', ' + subs if subs else ''})" | |||
|
|
|||
| def __eq__(self, other): | |||
There was a problem hiding this comment.
As a rule, overriding eq should also override hash. But I think, as long as the equality gets reduced, equality still implies hash equality.
There was a problem hiding this comment.
I think that implementing a __hash__ for sub-class of CaselessDict is not straightforward as per [this](https://github.com/collective/icalendar/pull/391/files#r957502946}
| # check for set equivalence. We have to iterate over the subcomponents | ||
| # and look for each of them in the list. | ||
| for subcomponent in self.subcomponents: | ||
| if subcomponent not in other.subcomponents: |
There was a problem hiding this comment.
this is a subset test. a == b does not imply b == a.
…components as equal to the bigger component
|
I think it is perfect. |
|
I guess, we can create a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #526