Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope for queue negation #194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

njakobsen
Copy link

This PR adds support for handling the exclude_specified_queues flag on the worker, added in collectiveidea/delayed_job#1148. This flag indicates whether the list of queues is an inclusion or exclusion filter, allowing delayed job to create worker pools that process any jobs except those in the list of queues.

A worker can now opt to exclude the given queues by setting the `exclude_specified_queues` option.
If we have jobs without a queue they should be returned by `not_for_queues` unless one of the queues we don't want is specifically `nil`.
When shutting down and releasing jobs, we should still respect the `ActiveRecord.configuration.reserve_sql_strategy` and clear locks using explicit job ids if the strategy is `:default_sql`. This can help avoid transaction isolation conflicts when shutting down several job runners.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant