Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammonite 3.0.0 isn't published for Scala 3.3.3 #1563

Open
Gedochao opened this issue Sep 25, 2024 · 6 comments
Open

Ammonite 3.0.0 isn't published for Scala 3.3.3 #1563

Gedochao opened this issue Sep 25, 2024 · 6 comments

Comments

@Gedochao
Copy link
Contributor

scala-cli -S lts --amm --power --ammonite-version 3.0.0
# Downloading Ammonite 3.0.0
# Downloading Ammonite 3.0.0 sources
# [error]  Can't download Ammonite 3.0.0 for Scala 3.3.3.
# Ammonite with this Scala version might not yet be supported.
# Try passing a different Scala version with the -S option.

while it works fine with 3.0.0-M2-15-9bed9700

scala-cli -S lts --amm --power --ammonite-version 3.0.0-M2-15-9bed9700
# Downloading Ammonite 3.0.0-M2-15-9bed9700
# Downloading Ammonite 3.0.0-M2-15-9bed9700 sources
# Loading...
# Welcome to the Ammonite Repl 3.0.0-M2-15-9bed9700 (Scala 3.3.3 Java 17)
# @
@lihaoyi
Copy link
Member

lihaoyi commented Sep 25, 2024

This is expected because upickle does not support scala 3.3.3 due to a compiler macro issue IIRC, so both only support 3.4.2 and above

@Gedochao
Copy link
Contributor Author

Right. So we should downgrade to 3.0.0-M2-15-9bed9700 for Scala <3.4.2. 😞 Got it.

@lihaoyi
Copy link
Member

lihaoyi commented Sep 25, 2024

Once Scala 3.3.4 or 3.3.5 comes out we can add back support in Ammonite 3.x, see this pr for details com-lihaoyi/upickle#610

@Gedochao
Copy link
Contributor Author

Yeah... it's slightly awkward where I'd have to do special handling for <3.4.2 for the time being... or just not upgrade ammonite in Scala CLI until the fix is in place.
Leaning towards the latter.

Also, iI find it a bit odd for this to be introduced in Ammonite 3.0.0 (the first stable release since 2.5.11). This is essentially removing Scala LTS support, even if it's temporary... 😕

@lihaoyi
Copy link
Member

lihaoyi commented Sep 25, 2024

I'd say just don't upgrade if it's inconvenient. If I didn't publish Ammonite 3.0.0, that's what you would be doing anyway. Ammonite 3.0.0 has been overdue for years now, so I wanted it out sooner rather than later, and I didn't want to hold back everyone on 2.12/2.13/3.4/3.5 just because some bugs in 3.3.3 haven't been fixed yet

@Gedochao
Copy link
Contributor Author

BTW Scala 3.3.4 artifacts are up, not sure if that doesn't help already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants