Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Add FW for 2024 Hyundai Tucson #1289

Closed
wants to merge 3 commits into from

Conversation

Curtrahmel
Copy link

Added "b'\xf1\x00NX4 FR_CMR AT USA LHD 1.00 1.00 99211-CW020 14Z'," to "CAR.HYUNDAI_TUCSON_4TH_GEN: {"

This has been verified and tested on road with sunnypilot dev-c3 with daily drives for the past 3 months without issue.

Added "b'\xf1\x00NX4 FR_CMR AT USA LHD 1.00 1.00 99211-CW020 14Z'," to "CAR.HYUNDAI_TUCSON_4TH_GEN: {"
@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Sep 26, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@jyoung8607
Copy link
Collaborator

Looks like CI is blocked on a common issue with Tucson ICE and Hybrid firmware overlapping. This has been an issue for awhile, not sure of current state. I'll check with the openpilot team to see what we can be done.

@jyoung8607 jyoung8607 self-assigned this Oct 2, 2024
@jyoung8607 jyoung8607 changed the title Update fingerprints.py for 2024 HYUNDAI_TUCSON HKG: Add FW for 2024 Hyundai Tucson Oct 2, 2024
@Curtrahmel
Copy link
Author

Curtrahmel commented Oct 2, 2024 via email

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 13, 2024
@Curtrahmel
Copy link
Author

Any updates on this?

@github-actions github-actions bot removed the stale label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 1, 2024
@github-actions github-actions bot removed the stale label Dec 2, 2024
@Curtrahmel Curtrahmel closed this by deleting the head repository Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants