Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma Serial Documentation Cleanup #33374

Closed
wants to merge 1 commit into from
Closed

Comma Serial Documentation Cleanup #33374

wants to merge 1 commit into from

Conversation

samehmohamed88
Copy link
Contributor

Comma Serial Documentation Cleanup

@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the tools label Aug 25, 2024
adeebshihadeh
adeebshihadeh requested changes Aug 28, 2024
View reviewed changes
tools/serial/README.md

On the comma 3X, the serial console is accessible through the `panda` use the script
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't a sentence

@adeebshihadeh
Copy link
Contributor

This is just copy-pasted from docs.comma.ai! Real fix: d7f4fbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samehmohamed88 @adeebshihadeh