ui: refactor spinner using raylib #33738
Draft
+162
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deanlee
commented
Oct 7, 2024
deanlee
commented
- Add selfdrive/ui/raylib/util.cc for Helper Functions: Introduced a new raylib/util.cc file containing utility functions to manage common tasks such as font handling, application initialization, and other reusable operations.
- refactor spinner using raylib:
deanlee
force-pushed
the
raylib_spinner
branch
from
6460cb4
to
2fccdb9
Compare
deanlee
force-pushed
the
raylib_spinner
branch
from
2fccdb9
to
1bad8b2
Compare
UI PreviewAll Screenshots
|
deanlee
force-pushed
the
raylib_spinner
branch
5 times, most recently
from
c8fdc0c
to
9c35827
Compare
Comment on lines
+59
to
+60
| Vector2 textSize = MeasureTextEx(getFont(), userInput.c_str(), kFontSize, 1.0); | ||
| DrawTextEx(getFont(), userInput.c_str(), {center.x - textSize.x / 2, yPos}, kFontSize, 1.0, WHITE); |
There was a problem hiding this comment.
make a helper for this?
| } | ||
| } | ||
|
|
||
| EndDrawing(); |
There was a problem hiding this comment.
raylib handles the FPS here?
There was a problem hiding this comment.
yes, raylib hand FPS and poll input events in EndDrawing().
|
@adeebshihadeh: Raylib failed to initialize GLFW on the C3X: The error occurs because two functions, To resolve this issue, we need to update Wayland on the device to the correct version and ensure raylib is compiled with the appropriate build options ( https://github.com/raysan5/raylib/blob/3fb1ba25aca0a6b023ca254a0910df36b0744e64/CMakeOptions.txt) |
|
Unfortunately, we can't easily update our Weston. Can we just patch those out in raylib? |
deanlee
force-pushed
the
raylib_spinner
branch
from
9c35827
to
10afe41
Compare
|
Getting this error building on device: |
deanlee
force-pushed
the
raylib_spinner
branch
from
10afe41
to
5ded054
Compare
@adeebshihadeh: fixed this build issue |
|
@maxime-desroches can you get this working on-device? It's likely easiest to patch raylib to work with our existing weston. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.