athenad: ensure no duplicate items in upload queue with snapshot approach #34192
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves performance and thread safety in the
uploadFilesToUrlsfunction. Instead of repeatedly callinglistUploadQueue()within the loop, it captures a snapshot of the upload queue’s URLs at the beginning of the function. This snapshot is then used to check for duplicates, preventing the addition of items that are being taken from the upload queue by theupload_handlerthread during the loop.this approach improves stability, boosts efficiency, and reduces lock contention from repeated queue locking within the loop.