Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ford - reset steering angle state when driver stops overriding steering #2064

Closed

Conversation

pfeiferj
Copy link

@pfeiferj pfeiferj commented Oct 19, 2024

Currently if the driver manually steers faster than the angle rate limits for Ford (and others) then openpilot will not be able to resume from the current curvature/steering angle until the rate limit catches up to the actual state.

This resets the steering angle with the previous measured angle upon detecting the user has stopped overriding. This means that rate limit clips will be centered on the currently measured angle for the first frame after done overriding.

@sshane
Copy link
Contributor

sshane commented Oct 26, 2024

I don't think we want this in panda. You can achieve something similar by making latActive go low under high angle rate events in openpilot. With the doubling of the curvature rate limits in #2065, we are now almost fully limited by the EPS's wind down limits after turns (but it's still much better).

@sshane sshane closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants