fix: fix ui language dropdown not being shown without also having ski…

…pped sentences (#566)
common-voice · Nov 25, 2021 · 767cdec · 767cdec
1 parent 390bc6b
commit 767cdec
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/web/src/components/profile/settings.test.tsx b/web/src/components/profile/settings.test.tsx
@@ -29,6 +29,11 @@ test('should render title', async () => {
   expect(screen.getByText('Settings')).toBeTruthy();
 });
 
+test('should render ui language section', async () => {
+  await renderWithLocalization(<Settings />);
+  expect(screen.getByText('Interface Language')).toBeTruthy();
+});
+
 test('should render error message', async () => {
   (redux.useSelector as jest.Mock).mockImplementation(() => ({
     showErrorMessage: true,

diff --git a/web/src/components/profile/settings.tsx b/web/src/components/profile/settings.tsx
@@ -24,10 +24,6 @@ export default function Settings() {
     dispatch(resetSkippedSentences());
   };
 
-  if (!skippedSentences || skippedSentences.length === 0) {
-    return null;
-  }
-
   const onLanguageSelect = (locale: string) => {
     history.push(`/${locale}/profile`);
   };
@@ -77,17 +73,19 @@ export default function Settings() {
           )}
         </section>
 
-        <section className="settings-section">
-          <Localized id="sc-settings-reset-skipped">
-            <h3></h3>
-          </Localized>
-          <Localized id="sc-settings-skipped-decription">
-            <p></p>
-          </Localized>
-          <button className="standalone" onClick={resetSkipped}>
-            <Localized id="sc-settings-show-all-button" />
-          </button>
-        </section>
+        {skippedSentences && skippedSentences.length > 0 && (
+          <section className="settings-section">
+            <Localized id="sc-settings-reset-skipped">
+              <h3></h3>
+            </Localized>
+            <Localized id="sc-settings-skipped-decription">
+              <p></p>
+            </Localized>
+            <button className="standalone" onClick={resetSkipped}>
+              <Localized id="sc-settings-show-all-button" />
+            </button>
+          </section>
+        )}
       </section>
     </section>
   );