Idva5 1269/test structure of csv file #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Service to handle getting the file from file-transfer-service and retrying the download if the file is still doing AV scan
Added unit test for get request
…-file' into IDVA5-1269/test-structure-of-csv-file
|
looks good so far. 👍 |
…-file' into IDVA5-1269/test-structure-of-csv-file
sampankumar
reviewed
Oct 22, 2024
|
|
||
|
|
||
| private Boolean isValidFieldHeaders(CSVRecord record) { | ||
| List<String> actualHeaders = record.toList(); |
There was a problem hiding this comment.
Will the order matter? If not then we might have to get the index of column dynamically based on the name of the column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description outlining key changes/additions
Adding validation for each of the cells in the CSV file
JIRA Ticket Number
IDVA5-1269
Type of change
Pull request checklist
An exhaustive list of peer review checks can be read here