Skip to content

Commit

Permalink
Merge pull request #1346 from compas-dev/update/rhino-point-conversion
Browse files Browse the repository at this point in the history
Update/rhino point conversion
  • Loading branch information
Licini authored Apr 30, 2024
2 parents c2516e9 + 9454699 commit a11d447
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Changed use of `compas.geometry.allclose` to `compas.tolerance.TOL.is_allclose`.
* Changed use of `compas.geometry.close` to `compas.tolerance.TOL.is_close`.
* Changed imports of itertools to `compas.itertools` instead of `compas.utilities`.
* Updated `compas_rhino.conversions.point_to_compas` to allow for `Rhino.Geometry.Point` as input.

### Removed

Expand Down
11 changes: 9 additions & 2 deletions src/compas_rhino/conversions/geometry.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from __future__ import print_function

import Rhino # type: ignore
from System import MissingMemberException # type: ignore

from compas.geometry import Frame
from compas.geometry import Plane
Expand Down Expand Up @@ -103,14 +104,20 @@ def point_to_compas(point):
Parameters
----------
point : :rhino:`Rhino.Geometry.Point3d`
point : :rhino:`Rhino.Geometry.Point3d` | :rhino:`Rhino.Geometry.Point`
Returns
-------
:class:`compas.geometry.Point`
"""
return Point(point.X, point.Y, point.Z)
try:
return Point(point.X, point.Y, point.Z)
except MissingMemberException:
try:
return Point(point.Location.X, point.Location.Y, point.Location.Z)
except MissingMemberException:
raise TypeError("Unexpected point type, got: {}".format(type(point)))


def vector_to_compas(vector):
Expand Down

0 comments on commit a11d447

Please sign in to comment.