-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predicates2 new methods addition #1153
Open
baehrjo
wants to merge
181
commits into
compas-dev:main
Choose a base branch
from
baehrjo:predicates2-new-methods-addition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Predicates2 new methods addition #1153
baehrjo
wants to merge
181
commits into
compas-dev:main
from
baehrjo:predicates2-new-methods-addition
+14,620
−7,512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ed2229b.
Co-authored-by: beverlylytle <[email protected]>
Co-authored-by: beverlylytle <[email protected]>
Fix release name
lock python 3.7
bug fix on `is_polygon_in_polygon_xy`
New small utility functions
…/baehrjo/compas into predicates2-new-methods-addition
@baehrjo i think you still need to merge main back into your branch, or rebase it onto main... |
Hello,
Sorry for the delay, done!
Best regards,
Joelle
On 24 Oct 2023, at 20:57, Tom Van Mele ***@***.***> wrote:
@baehrjo<https://github.com/baehrjo> i think you still need to merge main back into your branch, or rebase it onto main...
—
Reply to this email directly, view it on GitHub<#1153 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3MW2RUQAIQWT7D7SXWQ5SLYBAFRPAVCNFSM6AAAAAAY7M6N3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXHA2DGNBSG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added new predicates in
predicates_2
for both point/polygon(XY) and polygon/polygon(XY):polygon_to_polygon_relationship_xy
,point_to_polygon_relationship_xy
,is_intersection_polygon_polygon_xy
Full documentation provided in the methods comments. There are on purpose overlaps in what the methods are doing, for instance 'polygon_to_polygon_relationship_xy' first checks for intersection, then for containment, and if not deducts that the polygon is outside instead of calling separate methods. Separate methods ('is_polygon_in_polygon_xy', 'is_intersection_polygon_polygon_xy', ...) are still useful when looking for a True/False answer only.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.