Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Shapely offset using a plugin implementation.
There are a few things worth discussing about it, mainly concerning the different arguments that compas and shapely functions require. If we want to keep the existing compas functions, for backward compatibility, then we could add in the now-plugin functions and the in-class calls a few lines indication the different args a user can input depending on the backend they are using.
Additionally, I rephrased the original shapely corner style options from 'miter, bevel, round' to 'sharp, chamfer, sharp' to match the ones in Rhino. Seeing as most users of compas will be more familiar with Rhino's terminology and the potential addition of rhino plugins for them, I thought it's more fitting!
Let me know your thoughts :)
What type of change is this?
Checklist
CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.