Mesh to rhino #1171
Merged
Mesh to rhino #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@tomvanmele ping |
tomvanmele
approved these changes
Aug 9, 2023
| from Rhino.Geometry import Mesh as RhinoMesh | ||
|
|
||
| try: | ||
| # TODO: Why? |
There was a problem hiding this comment.
Ngons are not supported in older versions of Rhino
| continue # ignore degenerate faces | ||
| if f > 4: | ||
| if MeshNgon is None: | ||
| raise NotImplementedError("N-Gons are not supported in the current context!") |
| @@ -28,3 +28,8 @@ def from_cylinder(*args, **kwargs): | |||
| @plugin(category="factories", requires=["Rhino"]) | |||
| def from_sphere(*args, **kwargs): | |||
| return RhinoBrep.from_sphere(*args, **kwargs) | |||
|
|
|||
|
|
|||
| @plugin(category="factories", requires=["Rhino"]) | |||
There was a problem hiding this comment.
perhaps we need to revise this category a bit but not in this PR
| continue # ignore degenerate faces | ||
| if f > 4: | ||
| if MeshNgon is None: | ||
| raise NotImplementedError("Ngons mesh is not supported in the current context!") |
There was a problem hiding this comment.
perhaps "Ngons are not supported in this version of Rhino" is more useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following conversion functions to
compas_rhinomesh_to_rhinovertices_and_faces_to_rhinopolyhedron_to_rhinoThis conversion was previously done in the
draw_meshutility function so I changed it as to use the new conversion functions.Added
RhinoBrep.from_meshWhat type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.