Artist refactoring #1175
Merged
Artist refactoring #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+12
| from compas.geometry import NurbsCurve | ||
| from compas.artists import Artist | ||
|
|
||
| Artist.clear() | ||
|
|
||
| curve = NurbsCurve.from_points([[0, 0, 0], [3, 3, 6], [6, -3, -3], [9, 0, 0]]) | ||
|
|
||
| artist = Artist(curve) | ||
| artist.color = (0.0, 1.0, 0.0) | ||
| artist.draw() | ||
|
|
||
| Artist.redraw() |
| artist.draw_vertices() | ||
| artist.draw_edges() | ||
| artist.draw_faces(color={face: Color.pink() for face in mesh.face_sample(size=17)}) | ||
| #artist.draw_vertexnormals() |
There was a problem hiding this comment.
Suggested change
| #artist.draw_vertexnormals() |
delete?
|
|
||
| point = Point(0, 0, 0) | ||
| artist = Artist(point) | ||
| # artist.color = (0.0, 1.0, 0.0) |
There was a problem hiding this comment.
Suggested change
| # artist.color = (0.0, 1.0, 0.0) |
delete? or uncomment?
Comment on lines
+11
to
+19
| # artist.color = (0.0, 1.0, 0.0) | ||
|
|
||
| # for i in range(11): | ||
| # artist.draw( | ||
| # color=Color.from_i(i / 10), | ||
| # point=[i, 0, 0], | ||
| # show_point=True | ||
| # ) | ||
|
|
There was a problem hiding this comment.
same, delete or uncomment?
src/compas/artists/artist.py
Outdated
Comment on lines
273
to
275
| # if not self._transformation: | ||
| # if hasattr(self._item, "transformation"): | ||
| # self._transformation = self._item.transformation |
There was a problem hiding this comment.
Suggested change
| # if not self._transformation: | |
| # if hasattr(self._item, "transformation"): | |
| # self._transformation = self._item.transformation |
delete?
| from .color import Color | ||
|
|
||
|
|
||
| class ColorDict(Data): |
There was a problem hiding this comment.
is it worth it to inherit from UserDict instead of implementing our own dict logic? Not a lot, but it would shave off a few lines of code that can be used directly from that class
| @@ -282,7 +282,7 @@ def from_three_colors(cls, c1, c2, c3): | |||
| return cls(colors) | |||
|
|
|||
| @classmethod | |||
| def from_rgb(cls): | |||
| def from_rgb(cls, n=256): | |||
There was a problem hiding this comment.
Add n to the docstrings, please
Co-authored-by: Gonzalo Casas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to simplify working with artists and to make the use of colors more transparent...
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.