Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix halfface _plane #1177

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Fix halfface _plane #1177

merged 4 commits into from
Sep 26, 2023

Conversation

romanarust
Copy link
Member

@romanarust romanarust commented Aug 26, 2023

Suggestion for changing the internal _plane storage of the Halfface from _plane[u][v][w] to _plane[u][v][fkey].

Reason:
Using u, v, w indices is problematic when 2 adjacent faces (f1key, f2key) share 3 vertices u, v, w.
if they also belong to the same cell, then.
_plane[u][v][w] = ckey
and
_plane[w][v][u] = ckey
however, _plane[w][v][u] is supposed to be the opposite cell to _plane[u][v][w].

Using the face key instead, the assignment becomes unique.
_plane[u][v][f1key] = ckey
_plane[v][u][f2key] = ckey
opposite cells:
_plane[v][u][f1key] = ckey_opposite
_plane[u][v][f2key] = ckey_opposite

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@romanarust romanarust merged commit 4fe88e2 into main Sep 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants