Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed syntax error when numpy is in path but IronPython #1185

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

chenkasirer
Copy link
Member

Fixes #1184.

Spotted this issue on some computers where COMPAS has been installed for he first time.
Problem seems to be the presence of numpy in sys.path of IronPython. The import of numpy in encoders.py to determine if it's available raises a syntax error, probably due to python3 syntax used.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! That actually makes a lot of sense, I didn't realize an import of py3.x might throw an exception other than ImportError

@chenkasirer
Copy link
Member Author

LGTM! That actually makes a lot of sense, I didn't realize an import of py3.x might throw an exception other than ImportError

yes this seemed like such a crazy voodoo issue, but now suddenly makes a lot of sense. I find it crazy though how Ladybug add stuff to path like that..

@chenkasirer chenkasirer merged commit 59e3d4a into main Sep 27, 2023
12 checks passed
@chenkasirer chenkasirer deleted the bugfix/numpy_import branch September 27, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime error (SyntaxErrorException): unexpected token 'from' when importing compas
2 participants