-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible services for RPC #1206
Conversation
nice! |
# special.py
from compas.rpc import Server
from compas.rpc import Dispatcher
class SpecialService(Dispatcher):
def special(self):
return "special"
def start_service():
server = Server(("0.0.0.0", 1753))
service = SpecialService()
server.register_instance(service)
server.serve_forever()
if __name__ == "__main__":
import argparse
parser = argparse.ArgumentParser()
args, unknown = parser.parse_known_args()
start_service() # client.py
import os
from compas.rpc import Proxy
proxy = Proxy(service="special", cwd=os.path.dirname("__file__"))
proxy.special() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + feedback
src/compas/rpc/services/default.py
Outdated
# server.register_function(server.ping) | ||
# server.register_function(server.remote_shutdown) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
src/compas/rpc/services/special.py
Outdated
@@ -0,0 +1,42 @@ | |||
""" | |||
Minimal example of a "special" service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very convinced about the naming, "special" but why? What's special about it? :) Do you mean "Custom" or "UserDefined"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not it is just an example. perhaps it should be removed and the example added to the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.