Explicit methods for geometry and separate methods for doc objects #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
- Coverage 60.11% 60.09% -0.02%
==========================================
Files 207 207
Lines 22234 22234
==========================================
- Hits 13366 13362 -4
- Misses 8868 8872 +4 ☔ View full report in Codecov by Sentry. |
chenkasirer
reviewed
Jul 5, 2024
chenkasirer
reviewed
Jul 5, 2024
| A very simple filter that includes all faces is ``def facefilter(face): return True``. | ||
| Default parameter value is None in which case all faces are included. | ||
| cls: :class:`compas.geometry.Mesh`, optional | ||
| cls: :class:`compas.datastructures.Mesh`, optional |
There was a problem hiding this comment.
ah is this so you can get e.g. a Polyhedron instead?
There was a problem hiding this comment.
no, if you want a subclass of mesh instead of the default
chenkasirer
reviewed
Jul 5, 2024
| from compas.tolerance import TOL | ||
| from compas.geometry import Surface | ||
|
|
||
| # from compas.tolerance import TOL |
chenkasirer
reviewed
Jul 5, 2024
| @@ -2,21 +2,15 @@ | |||
| from __future__ import division | |||
| from __future__ import print_function | |||
|
|
|||
| import Rhino # type: ignore | |||
|
|
|||
| # import Rhino # type: ignore | |||
chenkasirer
reviewed
Jul 5, 2024
src/compas_rhino/objects.py
Outdated
| temp = mgeo.TopologyVertices.MeshVertexIndices(tvindex) | ||
| vindices.append(temp[0]) | ||
| return vindices | ||
| # def get_meshes(layer=None): |
chenkasirer
approved these changes
Jul 5, 2024
Co-authored-by: Chen Kasirer <[email protected]>
…into conversions-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.