Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Draw component for GH #1387

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Fix Draw component for GH #1387

merged 1 commit into from
Aug 29, 2024

Conversation

gonzalocasas
Copy link
Member

@gonzalocasas gonzalocasas commented Aug 29, 2024

I think the changes in scene/sceneobject's positional vs kwargs params affected this, the error message was quite odd, but indicated that it was getting a None for item.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.24%. Comparing base (2d32ec0) to head (b062adb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   60.25%   60.24%   -0.02%     
==========================================
  Files         207      207              
  Lines       22244    22244              
==========================================
- Hits        13404    13401       -3     
- Misses       8840     8843       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalocasas
Copy link
Member Author

/cc @LorinWiedemeier

Copy link
Member

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gonzalocasas gonzalocasas merged commit ebaaa77 into main Aug 29, 2024
17 of 18 checks passed
@gonzalocasas gonzalocasas deleted the fix-draw-component branch August 29, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants