Skip to content

Commit

Permalink
lintfixes
Browse files Browse the repository at this point in the history
  • Loading branch information
partouf committed Oct 14, 2023
1 parent d304d17 commit 41a2337
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
6 changes: 0 additions & 6 deletions bin/lib/installable/rust.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@

import functools
import os
import socket
import subprocess
from datetime import datetime, timedelta
from pathlib import Path
from typing import Dict, Any
from lib.nightly_versions import NightlyVersions

from lib.amazon import list_s3_artifacts
from lib.installable.installable import Installable
Expand All @@ -18,10 +16,6 @@

_LOGGER = logging.getLogger(__name__)

running_on_admin_node = socket.gethostname() == "admin-node"

nightlies: NightlyVersions = NightlyVersions(_LOGGER)


@functools.lru_cache(maxsize=512)
def s3_available_rust_artifacts(prefix):
Expand Down
2 changes: 1 addition & 1 deletion bin/lib/installation_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def check_output(self, args: List[str], env: Optional[dict] = None, stderr_on_st
check=True,
)

fulloutput = ''
fulloutput = ""
if output.stdout != None:
fulloutput += output.stdout.decode("utf-8")
if output.stderr != None:
Expand Down
5 changes: 3 additions & 2 deletions bin/lib/nightly_versions.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
from collections import defaultdict
from typing import Any, Dict
from typing import Any, Dict, Set
from lib.amazon import dynamodb_client
from lib.amazon_properties import get_properties_compilers_and_libraries


class NightlyVersions:
version_table_name: str = "nightly-version"
exe_table_name: str = "nightly-exe"
Expand Down Expand Up @@ -48,7 +49,7 @@ def collect_compiler_ids_for(self, ids: set, exe: str, compilers: Dict[str, Dict
def get_compiler_ids(self, exe: str):
self.load_ce_properties()

ids = set()
ids: Set = set()

self.collect_compiler_ids_for(ids, exe, self.cpp)
self.collect_compiler_ids_for(ids, exe, self.rust)
Expand Down

0 comments on commit 41a2337

Please sign in to comment.