Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glslang trunk #1423

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add glslang trunk #1423

merged 2 commits into from
Oct 29, 2024

Conversation

spencer-lunarg
Copy link
Contributor

for compiler-explorer/compiler-explorer#6883

confirmed locally this grabs the rolling release and creates a glslang-trunk going ./bin/ce_install glsl

@spencer-lunarg
Copy link
Contributor Author

(In the near future, might add Vulkan SDK versions, but assume most people, really just want ToT anyway)

glsl:
glslang:
type: ziparchive
dir: glslang-{name}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands this will install once (we don't reinstall all compilers every day, for obvious reasons :))

If you want it to install every night you'll need to add:

if: nightly
install_always: true

here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, that makes sense, added, hopefully it is good (I guess not sure how to test that the nightly configuration is correct locally)

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :)

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! I'll fix up anything that goes wrong from here!

@mattgodbolt mattgodbolt merged commit 16f3c3f into compiler-explorer:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants