Add ylc compiler

[Cr0a3]

Hi dear godbolt team,
I added a new compiler called ylc from my project ygen.
It is a rust package so i hope i done everything right.

DISCLAMER:
I did not test it locally because the ce_install script did not work

It's my first time to contribute to godbolt so please say everything i did wrong

Bye
Cr0a3

[mattgodbolt]

Hi!

Sorry - but we can't do this: the system has no sudo and installing rust like this won't work across all our systems.

I replied on the feature request you opened (and then closed) - you'll probably need us to help and/or work with you to add support for building rust-based compilers like we build all our other compilers (C, C++, python, Rust itself, etc) with our misc-builder or clang-builder or ***-builder repositories.

Just copying the binary here might not work long-term: this doesn't copy any DLLs it may need too. We can help with this though!

[Cr0a3]

Oh sorry, I did not think of this.
Luckily ylc does not depend on any dlls cuz it uses my own written code generation library.

Another way for builds is I could add a GitHub workflow which would build the toolchain in my main repo, release it with the commit id, which would then be downloadable (or just create a pr to misc-builder)

[mattgodbolt]

A PR to misc-builder means we would do the CI ourselves with infrastructure that "guarantees" it will run. But also an installable binary for an old Ubuntu would work too, or even better statically linked against MUSL to make it truly standalone.

Thanks!

[Cr0a3]

I changed it, so now it should download my pre build.
So it's now just a normal download

[mattgodbolt]

This will download and install just once - which is probably not what you want for a "newest".

If you would like this to be installed every night , we will need an:

if: nightly

and then something to make it want to install every time. Some things have nightly as the type but I think we can add:

always_install: true

too.

When you support tagged stable releases we can revist so only the nightly gets installed this way.

[mattgodbolt]

Thanks: confirmed this now works. But it will only install once. I assume that's OK as you didn't reply to the comments above.

[mattgodbolt]

This is missing the url: parameter. I suspect you need that. Maybe fetch should be url ?

RuntimeError: Missing required key 'url' in compilers/ygen/ylc newest

If I make that change locally then it does'nt know how to find "newest". You URL needs to somehow contain {name} in order to specify the target.

I can't see any releases on https://github.com/Cr0a3/ygen/releases so I don't know what URL you need to specify to download the built compiler.

[Cr0a3]

I made a little script which automatically builds my project and force pushes the changes to the build branch which this script should download

[mattgodbolt]

It does not do that.

[mattgodbolt]

You can test this locally with:

$ make ce
$ bin/ce_install install ygen

(this will try and instlal to /opt/compiler-explorer but you can specify the destination with some --options - check --help for example)

[Cr0a3]

You can test this locally with:

$ make ce
$ bin/ce_install install ygen

Thank you, i found out when using wsl (which i do) you cannot use /mnt/c/... as your location you need to use ~ as the location. (Typical wsl problem happens often).

Anyway it now locally works.
After the installation, ylc should now be usable:

$ /opt/compiler-explorer/ygen/bin/ylc --version
ylc v1.0 (c) Cr0a3

Thank you for all your support

[Cr0a3]

@mattgodbolt can you also help me over the compiler-explorer side of thinks. When testing locally i get the error:

info: Exes found: {"cmake":[],"ylc":[]}
info: Creating compilers: 0
info: Compilers created: 0
info: Fetching possible arguments from storage
error: Top-level error (shutting down): Unexpected failure, no compilers found! {"stack":"Error: Unexpected failure, no compilers found!\n    at main (file:///home/toni/compiler-explorer/app.ts:458:19)"}
Program /usr/bin/node ./app.ts --debug --language ylc exited with code 1

[mattgodbolt]

Thanks: confirmed this now works. But it will only install once. I assume that's OK as you didn't reply to the comments above.

[mattgodbolt]

@mattgodbolt can you also help me over the compiler-explorer side of thinks. When testing locally i get the error:

info: Exes found: {"cmake":[],"ylc":[]}

It's not finding any compilers: probably as you have added them to the "amazon" settings which is the correct place to get them on the live site. However, it's not the configuration your system will use (else it would try and run on our amazon setup).

You can test locally by either copying the config to ylc.local.properties (or symlink it) -- that way your local install will pick up and use the same settings as the AWS instances just for your language.

Sorry it's so complex! There's some docs on adding a compiler and adding a language that you may already have seen but I'll link here.

[mattgodbolt]

Oct/22 01:19 admin-node~/infra (main|✔) $ ldd /opt/compiler-explorer/ygen/bin/ylc
        linux-vdso.so.1 (0x00007ffda73fb000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x0000718fb85d4000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x0000718fb8200000)
        /lib64/ld-linux-x86-64.so.2 (0x0000718fb88a9000)
Oct/22 01:20 admin-node~/infra (main|✔) $ /opt/compiler-explorer/ygen/bin/ylc --version
ylc v1.0 (c) Cr0a3

Confirmed installed ok. thanks

[mattgodbolt]

(Noting that the path here is just "ygen" so you won't be able to add versions later without changing a few things)

[Cr0a3]

(Noting that the path here is just "ygen" so you won't be able to add versions later without changing a few things)

Oh, sorry I forgot to include it (can you quickly add the needed flag or should I create another pr)?

[mattgodbolt]

I'll have to do some work to change it on my side as it will have been baked into our permanent image. Will make that change now though.