This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Aggregators Min and Max call Ordering file #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve comunica/comunica#1212.
According to the spec, Min and Max should make use of the SPARQL ORDER BY ordering definition. I assume sparqlee implements this in
Ordering.ts
(Both the spec and the implementation are wild to me, so please correct me if this assumption is wrong).The issue also makes me wonder whether there are problems regardingThe other aggregators do call the regularFunctions so should work.date
(and similar types) within the other aggregators, since all aggregators call thetypedValue
of a literal. Before #163 this was always some basic JS type (if I recall correctly), but now there are also object typedValues, these do not implement the+
operator for example.